C++20 support#4
Closed
white238 wants to merge 6 commits into
Closed
Conversation
… around C++20's strict requirement that std::any not have incomplete types
tupek2
approved these changes
Mar 16, 2026
|
|
||
| vjps_.emplace_back([=](UpstreamStates&, const DownstreamState&) { | ||
| vjps_.emplace_back([this](UpstreamStates&, const DownstreamState&) { | ||
| std::cout << "vjp not implemented for step " << currentStep_ << std::endl; |
Collaborator
There was a problem hiding this comment.
Seems I should be handling error here better. but that is for another day.
Member
Author
|
This PR doesn't change the default C++ standard but does add a CI check to make sure it stays compatible with C++20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two compiler errors due to C++20 being more strict than C++17
Incomplete types are not allowed in
std::any:Implicit
thisis not allowed in lambdas